Difference between revisions of "User talk:JHenderson"
JHenderson (talk | contribs) |
m (Reply) |
||
| Line 30: | Line 30: | ||
[[User:JHenderson|JHenderson]] 05:34, 11 November 2007 (UTC) | [[User:JHenderson|JHenderson]] 05:34, 11 November 2007 (UTC) | ||
| + | |||
| + | :The cause of the issue you saw was that the constant name was not quoted in the define directive. Normally this would mean that you wish to define a constant whose ''name'' is the value of the given constant. However since the constant does not exist, PHP guesses that you probably meant to create the constant whose name you gave, so it does it but issues a warning. | ||
| + | |||
| + | :The other issue was caused by an error in the regular expression used for spam protection. | ||
| + | |||
| + | :[[User:Chrisc|chrisc]] 05:38, 11 November 2007 (UTC) | ||
Revision as of 05:38, 11 November 2007
It's not quite readable... I suggest removing font-size: 90%; from the pre rule on the CSS. I tried disabling that property manually with Firebug and it definitely looks more readable. Nicolas 17:30, 9 November 2007 (UTC)
I've removed the font-size: 90%.
chrisc 09:16, 10 November 2007 (UTC)
That looks much better, I also thought it looked a little small. In order to get this to display properly in a fixed-font rather than the default, I did have to change the theme CSS to remove the pre element from the list - the file changed was gumax_template.css - I just commented the pre element out on line 49; doesn't seem to have affected anything else.
Also, to get rid of the PHP error message we were seeing on the preview page, I set the php error_reporting value to 2039 for the ashighlight.class.php script. Kinda an ugly hack, but the returned error had to do with use of an undefined variable in a define call - which seemed odd to me. Again, seems to work, but probably not the most elegant solution.
JHenderson 19:50, 10 November 2007 (UTC)
- Hmm I'm still gettin' it.
Warning: preg_match() [function.preg-match]: Unknown modifier 'p' in /a/httpd/sites/wiki/export/includes/EditPage.php on line 645
Nicolas 03:35, 11 November 2007 (UTC)
- The error you're getting is not the one Jim was referring to. I've fixed the one you're seeing.
- chrisc 04:49, 11 November 2007 (UTC)
- I've fixed the root cause of this warning and removed the error_reporting suppression.
- chrisc 04:49, 11 November 2007 (UTC)
Chris, what was the root cause, and the fix for Nicolas' messge?
JHenderson 05:34, 11 November 2007 (UTC)
- The cause of the issue you saw was that the constant name was not quoted in the define directive. Normally this would mean that you wish to define a constant whose name is the value of the given constant. However since the constant does not exist, PHP guesses that you probably meant to create the constant whose name you gave, so it does it but issues a warning.
- The other issue was caused by an error in the regular expression used for spam protection.
- chrisc 05:38, 11 November 2007 (UTC)